search

open-dis / open-dis-java

Java implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7 :boom:
Other
44 stars 35 forks source link

Feature/variable datum set payload updates #77

Closed ewatz closed 3 years ago

ewatz commented 3 years ago

Submitting updates to VariableDatum, for inclusion in OpenDIS

leif81 commented 3 years ago

Thank-you @ewatz for this.

I have an issue. The whitespace changes within the PR are making it difficult for me to understand the change. Can you please undo the whitespace change for now and resubmit the PR?

ewatz commented 3 years ago

Sure thing and thanks for considering the change request!

V/R,

Eric Watz

ewatz@aptima.com

Aptima

480.254.9692 (mobile)

937.938.4068 (office)

From: Leif Gruenwoldt notifications@github.com Sent: Thursday, February 18, 2021 5:19:37 PM To: open-dis/open-dis-java open-dis-java@noreply.github.com Cc: Eric Watz ewatz@aptima.com; Mention mention@noreply.github.com Subject: [EXTERNAL] - Re: [open-dis/open-dis-java] Feature/variable datum set payload updates (#77)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Thank-you @ewatzhttps://usg02.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.com%2Fewatz&data=04%7C01%7C%7C40fcedd8376e42aa6b0d08d8d45b4779%7Cf84861f0b6824e298d67014158fc4021%7C0%7C0%7C637492835812228962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8r93u4r08vEdmSQXLFDvp8bg62XNQ4z%2BRvkkJlV4%2FCA%3D&reserved=0 for this.

I have an issue. The whitespace changes within the PR are making it difficult for me to understand the change. Can you please undo the whitespace change for now and resubmit the PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://usg02.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.com%2Fopen-dis%2Fopen-dis-java%2Fpull%2F77%23issuecomment-781672072&data=04%7C01%7C%7C40fcedd8376e42aa6b0d08d8d45b4779%7Cf84861f0b6824e298d67014158fc4021%7C0%7C0%7C637492835812228962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0kiOFm5Bpn4WfCrWv%2FIw6agODKAIwKUDai8Ocd4Rel8%3D&reserved=0, or unsubscribehttps://usg02.safelinks.protection.office365.us/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOTBC64GHO7MMVA2VJLDPMTS7WG7TANCNFSM4XZKEQQA&data=04%7C01%7C%7C40fcedd8376e42aa6b0d08d8d45b4779%7Cf84861f0b6824e298d67014158fc4021%7C0%7C0%7C637492835812228962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=l80l%2B6tw4wGvVEJDXxZp2sDDygGVUrcN1p6al368zUk%3D&reserved=0.

The information contained in this e-mail and any attachments from Aptima may contain confidential and/or proprietary information and is intended only for the named recipient to whom it was originally addressed. If you are not the intended recipient, any disclosure, distribution, or copying of this e-mail or its attachments is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by return e-mail and permanently delete the e-mail and any attachments. "

ewatz commented 3 years ago

@leif81 I think we can close this pull request, I created a revised pull request with the original whitespaces.