search

open-dis / open-dis-java

Java implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7 :boom:
Other
44 stars 35 forks source link

Deprecate DIS_DR_* and DIS_DeadReckoning classes #82

Closed leif81 closed 2 years ago

leif81 commented 2 years ago

In general, I think the previous Dead Reckoning DISDR implementation should be deprecated in favor of the single DIS_DeadReckoning class I recently added. For example, the previous DISDR implementations have thread safety issues open-dis/open-dis-java#41.

Originally posted by @camejia in https://github.com/open-dis/open-dis-java/issues/42#issuecomment-314625324

I believe Chris made a typo in that comment and was recommending use of the DeadReckoner class he wrote instead of the DIS_DeadReckoning and DISDR* classes.:

https://github.com/open-dis/open-dis-java/blob/master/src/main/java/edu/nps/moves/deadreckoning/DeadReckoner.java

Another advantage of DeadReckoner is that it has extensive unit tests:

https://github.com/open-dis/open-dis-java/blob/master/src/test/java/edu/nps/moves/deadreckoning/DeadReckonerTest.java

Other issues affecting the classes to be deprecated:

leif81 commented 2 years ago

If anyone has concerns with this sugestion can you please share. For example if you are using the original DISDR* implementation and cannot for some reason migrate to the DeadReckoner. Could you please share your thoughts. Thanks.