search

open-dis / open-dis-javascript

Javascript implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
11 stars 12 forks source link

EntityMarking seems unimplemented #13

Closed joeclarkia closed 1 year ago

joeclarkia commented 1 year ago

The dis7 EntityMarking.js files implements the marking character string as a single byte, instead of the specified 12 bytes (11 + NULL terminator). I have sample code that I believe will implement this correctly -- I will aim to commit this code to a forked repo (or I could put a patch here) for consideration.

leif81 commented 1 year ago

Thank-you @joeclarkia . Yes if you believe it's a bug we always welcome and encourage pull requests to fix them!

joeclarkia commented 1 year ago

Pull Request: https://github.com/open-dis/open-dis-javascript/pull/14