open-dis / open-dis-javascript

Javascript implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
11 stars 12 forks source link

Support for DIS 7 Electronic Emissions Systems #24

Open B1Dobbs opened 1 year ago

B1Dobbs commented 1 year ago

Noticed a comment in dis7/ElectronicEmissionsPdu that states 'Electronic emmissions systems THIS IS WRONG'. Then the initToBinary uses a Vector3Float instead of a class like DIS 6's ElectronicEmissionSystemData.

Are there any plans to fix this?

leif81 commented 1 year ago

Thank-you for the report @B1Dobbs

This library is primarily maintained by the community through pull requests as issues or enhancements like this as they are raised. If this issue is important for your use case please feel free to contribute a pull request. Am happy to review and merge changes that are contributed.

B1Dobbs commented 1 year ago

I appreciate the quick response! We'll probably look into adding this support a little later and will avoid using DIS7 Emission PDUs for now. Feel free to either close this ticket or leave it open for someone else to work on as well.