search

open-dis / open-dis-python

Python implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v7
BSD 2-Clause "Simplified" License
48 stars 31 forks source link

EmissionSystemBeamRecord.serialize incorrectly contains outputStream read calls instead of write #35

Closed jason-mckinney closed 2 years ago

jason-mckinney commented 2 years ago

https://github.com/open-dis/open-dis-python/blob/b640fa3acf9de5bfe7f2ecf6d2263a431dcc692d/opendis/dis7.py#L5350-L5359 EmissionSystemBeamRecord's serialize function implementation is incorrectly attempting to call outputStream.read_unsigned_byte and outputStream.read_unsigned_short, which do not exist, and should be writes.

The read calls need to be replaced with the correct write calls: outputStream.write_unsigned_byte and outputStream.write_unsigned_short