search

open-dis / opendis7-java

Project to provide a complete type-safe Java implementation of the DIS Protocol version 7 (IEEE 1278.1-2012) and SISO-REF-010 Enumerations specifications.
Other
6 stars 5 forks source link

Wrong case in file names #16

Closed federkamm closed 1 year ago

federkamm commented 2 years ago

I can't compile the project with lots of errors like

C:\path\to\opendis7-java\src-generated\edu\nps\moves\dis7\entities\chn\platform\land\CSSC6HY3Sawhorselauncher.java:31:
error: class CSSC6HY3SawhorseLauncher is public, should be declared in a file named CSSC6HY3SawhorseLauncher.java
public final class CSSC6HY3SawhorseLauncher extends EntityType

The problem is the wrong case in the file name CSSC6HY3Sawhorselauncher.java instead of CSSC6HY3SawhorseLauncher.java (with capital L in Launcher).

I can fix this locally on my machine but I think the repo should be updated as well. It's difficult however to generate a pull-request, since I'm on Windows and Git on Windows doesn't understand the file name has changed if it's only different by case. Maybe someone on Linux has to do it.

federkamm commented 2 years ago

I figured out how to make a pull request for this issue: #17

Since the changes are in src-generated, probably opendis7-source-generator has to be fixed in order to make the change permanent. However, this PR shows what should be changed.

brutzman commented 1 year ago

repo was fixed, thanks. closing stale branch.