Iff pdu improvements and Unsafe equalsImpl for object list attributes

open-dis / opendis7-java

Project to provide a complete type-safe Java implementation of the DIS Protocol version 7 (IEEE 1278.1-2012) and SISO-REF-010 Enumerations specifications.

Other

6 stars 5 forks source link

Iff pdu improvements and Unsafe equalsImpl for object list attributes #23

Closed mimmi-matalamaki-insta-fi closed 10 months ago

mimmi-matalamaki-insta-fi commented 11 months ago

We have generated code based on https://github.com/open-dis/opendis7-source-generator/pull/15 -pullrequest open in opendis7-source-generator project. We have added IFFPduTest.java and Mode5StatusRecord.java classes.

brutzman commented 10 months ago

We are first testing the opendis7-source-generator pull request first, in order to see if that handles these dependencies when updating via build all.

brutzman commented 10 months ago

We are committing and pushing the following files manually since all of the other changes were autogenerated files that are now superseded. Test results are satisfactory as shown by build.test.log.txt output.

edu.nps.moves.dis7.test.IFFPduTest.java
edu.nps.moves.dis7.utilities.Mode5StatusRecord

Wondering if the second class is better positioned next to IFFPduLayer3InterrogatorFormatData, IFFPduLayer3TransponderFormatData classes, and also renamed as

edu.nps.moves.dis7.test.IFFMode5StatusRecord

Feedback welcome. We plan to perform this refactoring if there are no objections.

mimmi-matalamaki-insta-fi commented 10 months ago

Hello, for us it is ofcourse okay that you refactor class names and the code the way you like it better.

brutzman commented 10 months ago

All opendis7-java source-code merges handled manually, all conflicts resolved.