search

open-dis / opendis7-java

Project to provide a complete type-safe Java implementation of the DIS Protocol version 7 (IEEE 1278.1-2012) and SISO-REF-010 Enumerations specifications.
Other
6 stars 5 forks source link

RadioType class is broken #8

Closed arrowsmith closed 10 months ago

arrowsmith commented 2 years ago

Hi @brutzman,

According to this page, the RadioType should contain only 6 fields, but the resulting implementation contains 7. It starts off with field names that match - EntityKind, Domain, Country, and then Category, but after that the implementation has Subcategory, Specific, and Extra, which are not in the standard. There's no mention of the Nomenclature, or Nomenclature version fields. Essentially, the unmarshalling pulls out 9 bytes from the PDU instead of the 8 bytes that it should for this field.

I noticed activity has picked up on the repo recently. Any chance of this one being fixed soon?

terry-norbraten commented 10 months ago

@arrowsmith The record components listed in the link you reference is out of date (we should either update, or take that site down as it's stale). The RadioType is implemented in accordance with the current standard.

Screen Shot 2023-11-12 at 09 45 45