search

open-dis / opendis7-source-generator

Project to generate a type-safe Java implementation of the DIS Protocol version 7, IEEE 1278.1-2012 and SISO-REF-010 Enumerations specifications.
Other
5 stars 10 forks source link

TransmitterPdu has double extraction of RadioID #11

Open arrowsmith opened 3 years ago

arrowsmith commented 3 years ago

Hi again Don @brutzman,

I have noticed the TransmitterPdu class extracts the RadioID field (ref) once inside the header field (see RadioCommsHeader class), and again separately in the radioNumber field. this causes an unnecessary shift of unmarshalling by 2 bytes. Removing it from the RadioCommsHeader class fixes the problem, but so does commenting out the local field to the TransmitterPdu class, and redirecting all calls to get/set of the RadioID to the embedded RadioCommsHeader instance's field. I'm not sure which way you want to go.

Let me know if you're the best POC, or if there's a preferred approach to raising these issues.

arrowsmith commented 3 years ago

Just in case, I'll tag the other repo members for awareness: @terry-norbraten / @blueoak / @leif81 .

brutzman commented 9 months ago

We think this is probably fixed by integration of pull request... Recommend adding (or providing) a test for ongoing confirmation.