search

open-dollar / od-contracts

Open Dollar stablecoin contracts
https://OpenDollar.com
Other
55 stars 8 forks source link

691 allow script gen #705

Closed MrDeadCe11 closed 3 months ago

MrDeadCe11 commented 3 months ago

closes #691 closes #694

allows gov scripts to be generated without a private key, and also added a generic script that can take target addresses and calldata to create prospoals.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.61%. Comparing base (5e2be44) to head (c01271c). Report is 3 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-dollar/od-contracts/pull/705/graphs/tree.svg?width=650&height=150&src=pr&token=SDTNS69Q36&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-dollar)](https://app.codecov.io/gh/open-dollar/od-contracts/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-dollar) ```diff @@ Coverage Diff @@ ## dev #705 +/- ## ======================================= Coverage 96.61% 96.61% ======================================= Files 58 58 Lines 1921 1921 ======================================= Hits 1856 1856 Misses 65 65 ```
MrDeadCe11 commented 3 months ago

Tried to run yarn propose -g gov-input/mainnet/new-TargetsAndCalldata.json and getting error

  [477737] GenerateTargetsAndCalldataProposal::run("/gov-input/mainnet/new-TargetsAndCalldata.json")

script failed: environment variable "ARB_MAINNET_PK" not found

I tried with both ARB_MAINNET_PK and without ARB_MAINNET_PK in my env

since we shouldn't need to load the private key at all for the generator scripts, I removed the 'loadPrivateKeys" command. also don't forget to use the -a flag as well to automatically fill in the contract addresses