open-dollar / od-sdk

MIT License
2 stars 1 forks source link

Fix proxy-action.ts network routing logic #64

Closed jahabeebs closed 6 months ago

jahabeebs commented 6 months ago

1) expose network in the constructor in proxy-actions 2) use network to route transactions

pi0neerpat commented 6 months ago

I thought this change was made specifically to enable optimism hai, without causing issues to arb-sepolia. But maybe I didn't implement it correctly?

https://github.com/open-dollar/od-sdk/blame/e728bfe9339b1dd2ca5b33ec25f04c3e236492d1/src/proxy-action.ts#L277

jahabeebs commented 6 months ago

I thought this change was made specifically to enable optimism hai, without causing issues to arb-sepolia. But maybe I didn't implement it correctly?

https://github.com/open-dollar/od-sdk/blame/e728bfe9339b1dd2ca5b33ec25f04c3e236492d1/src/proxy-action.ts#L277

The problem is both optimism and arbitrum-sepolia have a non-null GEB_TAX_COLLECTOR so at one point one of those networks did not have one and I must have relied on the this.addressList.GEB_TAX_COLLECTOR !== NULL_ADDRESS logic to stay the same

Screenshot 2024-04-03 at 5 10 22 PM
jahabeebs commented 6 months ago

@pi0neerpat I fixed the issue in this PR: https://github.com/open-dollar/od-sdk/pull/65

I guess we'll have to update the SDK with the above PR to merge this branch to dev since it includes the faulty routing logic