Closed jahabeebs closed 6 months ago
I thought this change was made specifically to enable optimism hai, without causing issues to arb-sepolia. But maybe I didn't implement it correctly?
I thought this change was made specifically to enable optimism hai, without causing issues to arb-sepolia. But maybe I didn't implement it correctly?
The problem is both optimism and arbitrum-sepolia have a non-null GEB_TAX_COLLECTOR so at one point one of those networks did not have one and I must have relied on the this.addressList.GEB_TAX_COLLECTOR !== NULL_ADDRESS
logic to stay the same
@pi0neerpat I fixed the issue in this PR: https://github.com/open-dollar/od-sdk/pull/65
I guess we'll have to update the SDK with the above PR to merge this branch to dev since it includes the faulty routing logic
this.addressList.GEB_TAX_COLLECTOR !== NULL_ADDRESS
however, this is preventing us from merging our optimism-hai branch into dev because this logic isn't valid since arbitrum sepolia now has a non null GEB_TAX_COLLECTOR in the latest SDK deployment1) expose network in the constructor in proxy-actions 2) use network to route transactions