Removes Gulp watch flag which conflicts with Node watch flag - Githubissues

open-duelyst / duelyst

Duelyst is a digital collectible card game and turn-based strategy hybrid, developed by Counterplay Games.

Creative Commons Zero v1.0 Universal

3.62k stars 556 forks source link

Removes Gulp watch flag which conflicts with Node watch flag #204

Closed willroberts closed 1 year ago

willroberts commented 1 year ago

Summary

Fixes endless Gulp builds due to mis-parsed --watch flags.

Build changes (docker/, gulp/, scripts/, etc.):

Disables the --watch flag for gulp-autowatch, since it conflicts with the new --watch flag in Node.js v18+: https://nodejs.org/en/blog/announcements/v19-release-announce/#node-watch-experimental
Updates docs to recommend managing Node.js versions with Volta

Testing

Have you have tested your changes in the following scenarios? Feel free to check off scenarios which don't apply.

[x] Starting backend services locally with docker compose up succeeds.
[x] I am able to create a new user and log in locally.
[x] I am able to complete a practice game locally.
[x] I am able to complete a purchase of Orbs, etc.