Wider null check for giftCrateTemplate - Githubissues

open-duelyst / duelyst

Duelyst is a digital collectible card game and turn-based strategy hybrid, developed by Counterplay Games.

Creative Commons Zero v1.0 Universal

3.61k stars 555 forks source link

Wider null check for giftCrateTemplate #267

Closed yoganlava closed 1 year ago

yoganlava commented 1 year ago

giftCrateTemplate can undefined and is checked if it === null. This is not true, this commit uses a better null check.

Hopefully closes #260

Summary

Describe your changes here. Remove any inapplicable sections.

Server changes (config/, server/, worker/, etc.):

Better null check for giftCrateTemplate

Testing

Have you tested your changes in the following scenarios? Feel free to check off scenarios which don't apply.

[x] Starting backend services locally with docker compose up succeeds.
[x] I am able to create a new user and log in locally.
[x] I am able to complete a practice game locally.
[x] I am able to complete a purchase of Orbs, etc.