open-dust / cairo-foundry

Foundry like framework for starknet contracts
MIT License
77 stars 32 forks source link

[HIGH PRIORITY] Have a new builtin processor that works with regex #41

Open Bernardstanislas opened 1 year ago

Bernardstanislas commented 1 year ago

Context

The cairo-rs vm has a trait HintProcessor, that is currently only implemented by their BuiltinHintProcessor.

This processor let us add custom hints, matching the hint code with an hardcoded string.

Goal

We want to go further with these custom hints, and be able to have a hint processor that will match hints based on a regex. This would let us provide arguments to the Rust hint function associated with a regex.

I did a PR for this in the vm repo, but it was suggested that this should live in our project directly.

You can find some documentation here to learn more about their hint processor concept: https://github.com/lambdaclass/cairo-rs/tree/main/docs/hint_processor

What we expect from you

oxlime commented 1 year ago

request to assign

Eikix commented 1 year ago

Hi, are you still participating on this issue?

oxlime commented 1 year ago

Yes sorry holidays. Will get it done next day or two.

Eikix commented 1 year ago

hey, no worries:)!

we're in a bit of a pickle right now, some of the contributors of cairo-foundry are currently at an off-site event in the French alps, and we're all "pair programming" together on some issues We chose this issue to move forward and better understand the cairo runner. We'll use it to onboard people.

we will do this issue in the chalet, but if you have free time these days, i'd be glad to assign you to another issue!

Eikix commented 1 year ago

let me know if you have free time and want to work on a specific issue:)

tdelabro commented 1 year ago

@bacharif is working on this one

tdelabro commented 1 year ago

Good to know, @Bernardstanislas already did a version of this one for the cairo-rs repo, it had been refused as they prefer not to include it to their codebase for now. Take inspiration from it: https://github.com/lambdaclass/cairo-rs/pull/524

bacharif commented 1 year ago

For me