updated config to prevent drop at the start. Addded record facility

MaximilienNaveau commented 4 years ago

Description

Changed the initial configuration of solo to prevent the robot from dropping from the air to the ground when starting the simulation. Also, added a functionality to record a simulation as a video.

I fulfilled the following requirements

[x] All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
[x] All new functions/classes are documented and existing documentation is updated according to changes.
[x] No commented code from testing/debugging is kept (unless there is a good reason to keep it).

avadesh02 commented 4 years ago

Changed the initial configuration of solo to prevent the robot from dropping from the air to the ground when starting the simulation. Also, added a functionality to record a simulation as a video.

jviereck commented 4 years ago

Thanks for providing this PR!

Fine about the initial position change. The recording API I would do a bit differently - see comment.

jviereck commented 4 years ago

Thanks @avadesh02 for the second iteration. There are a few small comments. If you don't have strong opinions I would like to see the filename one addressed in this PR.

Otherwise, I approved this PR. Feel free to merge once you think it's ready or ask for another round of feedback. Up to you.

open-dynamic-robot-initiative / robot_properties_solo

updated config to prevent drop at the start. Addded record facility #18

Description

I fulfilled the following requirements