open-dynamic-robot-initiative / robot_properties_solo

BSD 3-Clause "New" or "Revised" License
40 stars 20 forks source link

build xacro files at installation time; rename resources folder to 'r… #45

Closed huaijiangzhu closed 3 years ago

huaijiangzhu commented 3 years ago

…esources'

Description

This PR adopted similar changes in https://github.com/open-dynamic-robot-initiative/robot_properties_bolt/commit/179ab2a9e8d5cad1cd4dde1d8c88108864c14cf3 and https://github.com/open-dynamic-robot-initiative/robot_properties_bolt/commit/aaa6b78fad781e508240fcceb327825260525978

These include:

How I Tested

I installed the package using pip install . and ran the demos.

Do not merge before

I fulfilled the following requirements

huaijiangzhu commented 3 years ago

@jviereck any comments? otherwise I will merge the pr.

jviereck commented 3 years ago

Looks good to me. As Max was more involved with the refactoring before I relied on him giving you feedback.

About making bullet_utils available on pip, that sounds like a good idea.