Set serial_port to "auto" - Githubissues

open-dynamic-robot-initiative / robot_properties_solo

BSD 3-Clause "New" or "Revised" License

40 stars 20 forks source link

Set serial_port to "auto" #56

Closed luator closed 1 year ago

luator commented 1 year ago

Description

With an upcoming change in slider_box (https://github.com/open-dynamic-robot-initiative/slider_box/pull/2) the behaviour changes such that auto-detection is only done if the port is explicitly set to "auto". Thus changing it here to maintain the current behaviour.

This change is backwards compatible with older versions of slider_box as there auto-detection is done in any case.

How I Tested

Not tested.

I fulfilled the following requirements

[x] All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
[x] All new functions/classes are documented and existing documentation is updated according to changes.
[x] No commented code from testing/debugging is kept (unless there is a good reason to keep it).

luator commented 1 year ago

https://github.com/open-dynamic-robot-initiative/slider_box/pull/2 is merged now, so I'm merging this too.