open-ead / sead

Decompilation of sead: the standard C++ library for first-party Nintendo games
190 stars 26 forks source link

Accuracy issues in TreeMap and StrTreeMap #118

Open leoetlino opened 1 year ago

leoetlino commented 1 year ago
  1. remove the StrTreeMap dtor (it shouldn't exist – StrrTreeMap was copy/pasted from TreeMap, and I fixed TreeMap but forgot to fix StrTreeMap as well)
  2. move TreeMapImpl to its own header (seadTreeMapImpl.h)
  3. rewrite forEach to get rid of the odd-looking loop – LLVM optimised the tail recursive call and I didn't notice when I implemented forEach