Added dialog tags in Chapter 2, for issue #7

open-editions / corpus-joyce-portrait-TEI

The Open Scholarly Edition of James Joyce's A Portrait of the Artist as a Young Man

GNU General Public License v3.0

20 stars 20 forks source link

Added dialog tags in Chapter 2, for issue #7 #51

Closed rdeal25 closed 8 years ago

rdeal25 commented 8 years ago

Done with Chapter 2 for issue #7!

This chapter was fairly simple re: dialog attribution, but I remember when reading Portrait the first time a few years ago that the dialog could be confusing/difficult to attribute because of how Joyce mixes the present with memories.

JonathanReeve commented 8 years ago

This looks great! Thanks! And you did all of Chapter 2, it looks like, so I've just checked that off the todo list in #7. Fantastic. One minor suggestion: could you edit your pull request description to briefly describe your experience with editing this chapter, and/or your observations about the process of marking up dialog attributions? I think that would be a great record to have for posterity. Apart from that, everything looks awesome.

JonathanReeve commented 8 years ago

Looks great. Merging your edits into the project.