Closed garrettdonnelly closed 8 years ago
Looks great! The tags should actually be <persName>
and <placeName>
, in camelCase, rather than <persname>
and <placename>
, but that's OK--I'll just do a global find/replace on it at some point. (Opened #55 about this. Feel free to tackle it if you like, but don't feel like you have to.)
And these are really interesting edge-cases! Last names are typically good (the more information the better), and something like who="mad nun"
wouldn't be out of place with the current markup. The reference to the Metamorphoses would be for #35. We don't have a markup convention for that yet, but I imagine it'd be something like <cit>
or even the allusion form of att.interpLike.
Anyway, great stuff! Merging into the project.
Whoops. Just noticed the missing </said>
tags you mentioned in your email. Opened #56 for that. Feel free to fix it if you have time. Otherwise I'll get to it, eventually.
Note: Just read over the guidelines again - only thing I forgot was to add the to the back end of the spoken lines. I can't right now, but I'll go back over all this tomorrow and make another pull request with just those edits, then I figure you can approve both at once. Sorry about that! Wasn't sure how to edit my original commit. If there's a way, let me know. My first comments are below.
Hey! Went through lines 6256-6638 and added persname, placename, and any spoken lines (said who="XXX"). Notes are below. Loved working on this - neat way to close read. Let me know how I can keep helping!