Closed razvand closed 1 year ago
@gabrielmocanu, I applied your comments. See the last two commits.
@razvand add the Makefile and build files from the oer-template
repo here so I can test this and merge it: https://github.com/open-education-hub/oer-template/pull/9.
@teodutu this currently does not follow the structure stated in the methodology
Yup, but at least it's closer. Restructuring the repo according to the updated methodology is probably an unrealistic goal until tomorrow.
@teodutu, @gabrielmocanu the rendered version link [1] does not work.
[1] http://open-education-hub.github.io/operating-systems/317/
@teodutu, @gabrielmocanu the rendered version link [1] does not work.
[1] http://open-education-hub.github.io/operating-systems/317/
Render it again. Probably another PR was merged.
@teodutu , I'll check this later today, so we can integrate it.
I finally fixed the errors. @razvand @Alex-deVis take a look at the restructured Software Stack chapter [1] and see if you like it.
[1] https://open-education-hub.github.io/operating-systems/317/Software%20Stack/
@teodutu, I think it would be better to put the Mini-libc
project under software-stack/projects
rather than software-stack/libc/projects
as this is a project for the whole chapter, not only for that section.
I find it more intuitive for questions/
to contain a list of quizzes, each file named after the quiz, not after the chapter. If you want students to solve a certain question after reading a chapter you can simply reference it.
To put it simply: libc/drills/questions
should contain 6 files (each being a quiz): printf() system call
, strcpy() system call
, printf() vs write()
...
Also, even if it is repetitive, I think it is a good idea to keep the Assignments page as it helps to find projects quickly.
These points aside, everything looks good and we should merge it ASAP. We can make changes based on live feedback in the following weeks.
@Alex-deVis I think the subchapters need to be split into another category such that the sidebar looks like this:
Software Stack:
|-- Slides
|-- That other category
| |-- Overview
| |-- ...
| `-- Applications
`-- Projects
How to name "That other category"?
On second thought, I think we should stick to the methodology and nest mini-libc
under libc
because that's what is closest to it.
IMO the idea of a project is something tied to the chapter as a whole (in this case to Software Stack
), but I do not mind the current form as long as we keep the Assignments
section for accessibility.
Whatever gets this merged faster.
Restructure repository according to Open Education Hub Methodology.