open-eid / DigiDoc4-Client

DigiDoc4 Client is an application for digitally signing and encrypting documents; the software includes functionality to manage Estonian ID-card - change pin codes etc.
https://www.id.ee/en/article/install-id-software/
Other
116 stars 41 forks source link

version 4.3.0 build fail #1207

Closed Pro-pra closed 12 months ago

Pro-pra commented 12 months ago

Hi all, my build fail with errors:

/var/lib/notamock/BUILD/BUILD/qdigidoc4-4.3.0/client/Application.cpp:168:40: error: 'std::vector<digidoc::X509Cert> DigidocConf::TSCerts() const' marked 'final', but is not virtual
  168 |         std::vector<digidoc::X509Cert> TSCerts() const final
      |                                        ^~~~~~~
/var/lib/notamock/BUILD/BUILD/qdigidoc4-4.3.0/client/Application.cpp:211:14: error: 'void DigidocConf::setVerifyServiceUri(const std::string&)' marked 'final', but is not virtual
  211 |         void setVerifyServiceUri(const std::string &url) final
      |              ^~~~~~~~~~~~~~~~~~~
/var/lib/notamock/BUILD/BUILD/qdigidoc4-4.3.0/client/Application.cpp: In member function 'std::vector<digidoc::X509Cert> DigidocConf::TSCerts() const':
/var/lib/notamock/BUILD/BUILD/qdigidoc4-4.3.0/client/Application.cpp:171:93: error: could not convert 'cert' from 'digidoc::X509Cert' to 'bool'
  171 |                 if(digidoc::X509Cert cert = toCert(fromBase64(QVariant(Settings::TSA_CERT))))

gcc 13.1.0 CXXFLAGS=-O2 -fomit-frame-pointer -gdwarf-4 -Wstrict-aliasing=2 -pipe -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -fstack-protector-strong --param=ssp-buffer-size=4 -m64 -mtune=generic -flto=auto -fno-fat-lto-objects -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++17 -MD -MT

metsma commented 12 months ago

You need update libdigidocpp

Pro-pra commented 12 months ago

thank you!