search

open-eid / DigiDoc4-Client

DigiDoc4 is an application for digitally signing and encrypting documents; the software includes functionality to manage Estonian ID-card - change pin codes etc.
https://www.id.ee/en/article/install-id-software/
Other
120 stars 42 forks source link

Download resources when they do not exist in source folder #1277

Closed metsma closed 4 months ago

metsma commented 5 months ago

IB-8136, Fixes #1274

Signed-off-by: Raul Metsma raul@metsma.ee

LecrisUT commented 5 months ago

Only 1 issue, CMAKE_CURRENT_SOURCE_DIR in common does not point to the SOURCE_DIR of the top-level project (it is pointing to /common instead of /). It is possible to work with that, but is that the intended design? I.e. if common is meant to only be used via add_subdirectory, than CMAKE_SOURCE_DIR would be a better alternative.

Similar with TSL.qrc, should be in / or /client?

metsma commented 4 months ago

Only 1 issue, CMAKE_CURRENT_SOURCE_DIR in common does not point to the SOURCE_DIR of the top-level project (it is pointing to /common instead of /). It is possible to work with that, but is that the intended design? I.e. if common is meant to only be used via add_subdirectory, than CMAKE_SOURCE_DIR would be a better alternative.

Similar with TSL.qrc, should be in / or /client?

Updated the instructions https://github.com/open-eid/DigiDoc4-Client/wiki/DeveloperTips#building-in-sandboxed-environment