search

open-eid / chrome-token-signing

DEPRECATED Chrome and Firefox extension for signing with your eID on the web
https://github.com/open-eid/chrome-token-signing/wiki
GNU Lesser General Public License v2.1
206 stars 75 forks source link

ACS Cryptomate, AKIS and Turkish support #120

Closed kurtuluso closed 4 years ago

kurtuluso commented 5 years ago

ACS Cryptomate token and AKIS card supports have been added for Mac OSX, Linux and windows. Turkish language support has been added. All done by extending the features in scope of current design.

metsma commented 5 years ago

Can somebody add also signed off line to commit message https://github.com/open-eid/org/blob/master/CONTRIBUTING.md

martinpaljak commented 5 years ago

And squash the commits to a few meaningful ones.

kurtuluso commented 5 years ago

Is there anything we have to do about the pull request?

martinpaljak commented 5 years ago

First please make it reviewable, by fixing the comments and then squashing it to either a single or a well comprehensible number of separate commits, against current master

metsma commented 5 years ago

Please can we split the pull request. Translations/Driver changes/Multi signing/Build changes