search

open-eid / chrome-token-signing

DEPRECATED Chrome and Firefox extension for signing with your eID on the web
https://github.com/open-eid/chrome-token-signing/wiki
GNU Lesser General Public License v2.1
206 stars 75 forks source link

Multi signing #152

Closed kurtuluso closed 1 year ago

kurtuluso commented 4 years ago

The multi-signing made possible by sending concatenated multiple hashes. Total number of hashes are calculated by the size of the message or by the hashcount variable (if exist) coming from the browser. ~70 hashes (SHA256) can be signed at the same time. The total number of hashes is limited by the message size which is 1024*8 now. Single PIN is enough for PKCS11Signer; all hashes are signed without asking each time. Separate PIN is required for NativeSigner; PIN dialog appears for each hash consecutively.

kristelmerilain commented 3 years ago

Thank You for the contribution. Unfortunately, we cannot accept your pull request, as it contradicts with the Information System Authority position on multi-signing. Link for more information: https://www.id.ee/en/article/we-recommend-using-an-e-seal-instead-of-mass-signing-with-the-id-card/ We will leave your pull request open to interested parties. If you have any more questions then contact our support via help@ria.ee.

kurtuluso commented 3 years ago

Thank you for your response. We have to continue this feature on our own branch. We're updating the codes on our branch but how can I update safari extension? Where is the code to change safari ? In the release page (https://github.com/open-eid/chrome-token-signing/releases/tag/v1.1.4) There is a safari signing package. How can we produce similar package?

metsma commented 3 years ago

Thank you for your response. We have to continue this feature on our own branch. We're updating the codes on our branch but how can I update safari extension? Where is the code to change safari ? In the release page (https://github.com/open-eid/chrome-token-signing/releases/tag/v1.1.4) There is a safari signing package. How can we produce similar package?

There is Github Actions setup https://github.com/open-eid/chrome-token-signing/blob/master/.github/workflows/build.yml#L18-L19

kristelmerilain commented 1 year ago

I will close this pull request since the active development and management of the Token Signing component has ended due to the transition to the new web authentication and signing solution (Web eID). We are happy to accept your proposals in the new Web eID project repository: https://github.com/web-eid.