search

open-eid / chrome-token-signing

DEPRECATED Chrome and Firefox extension for signing with your eID on the web
https://github.com/open-eid/chrome-token-signing/wiki
GNU Lesser General Public License v2.1
206 stars 75 forks source link

mini.LECTOR-S doesnt work with few last versions #181

Closed horakivo closed 3 years ago

horakivo commented 3 years ago

We are using mini.LECTOR-S token to sign and it doesnt work with the last versions. I have build all the versions to find the last working version which is v1.0.7.

EDIT: I did some digging and I found out that the commit: 757d8e3f4b68283c926ca0fced64a253120364b6 break the signing module. To be more precise it ends in condition if ((type & (NCRYPT_IMPL_HARDWARE_FLAG | NCRYPT_IMPL_REMOVABLE_FLAG)) == 0) where in my case type is 0.

I dont know a lot about signing, but can someone explain why the case was changed?

Thanks!

metsma commented 3 years ago

Project requires that Token is on Hardware device or smartcard.

horakivo commented 3 years ago

Well mini.LECTOR-S is hardware device which which contains token. Can you explain your answer more?

metsma commented 3 years ago

Then I wonder why the provider minidriver/CSP does not expose the hardware flags? Can you provide some info about its middleware?

horakivo commented 3 years ago

About middleware? I am not sure where to get info about middleware.. Will this info help? https://prnt.sc/vgkqpe

metsma commented 3 years ago

Does device manager list "smart card reader" and "smart card" drivers?

horakivo commented 3 years ago

It just list "smart card reader". Took a screenshot. https://prnt.sc/vgl8kb

metsma commented 3 years ago

Hmm intresting can you produce logs with ole and new version of chrome token signing https://github.com/open-eid/chrome-token-signing/wiki/DeveloperTips#logging

horakivo commented 3 years ago

non-working version.txt working version.txt

Here are logs

metsma commented 3 years ago

I really don't know why this device claims that it is not hardware token. Right now there is only solution to comment out the check. Project scope is to only allow sign with hardware tokens.

kristelmerilain commented 3 years ago

Closing this issue because currently there are no plans to allow signing with software token.