open-eid / chrome-token-signing

DEPRECATED Chrome and Firefox extension for signing with your eID on the web
https://github.com/open-eid/chrome-token-signing/wiki
GNU Lesser General Public License v2.1
206 stars 75 forks source link

AUTH filter invalid_argument with version 1.1.3 #192

Closed smartman closed 3 years ago

smartman commented 3 years ago

After latest upgrade AUTH filter is not working anymore and invalid_argument is returned. SIGN filter still works. It was still working with version 1.1.2.something

2021-01-29 06:45:41 main() [chrome-token-signing.cpp:63] Parsing input... 2021-01-29 06:45:41 readMessage() [chrome-token-signing.cpp:43] Request(132): {"type":"CERT","lang":"en","filter":"AUTH","nonce":"hrkac021umq53h62","src":"page.js","origin":"https://hwcrypto.github.io","tab":2} 2021-01-29 06:45:41 main() [chrome-token-signing.cpp:115] Handling exception: invalid_argument 2021-01-29 06:45:41 sendMessage() [chrome-token-signing.cpp:51] Response(84) { "message": null, "nonce": "hrkac021umq53h62", "result": "invalid_argument" }

2021-01-29 06:48:25 main() [chrome-token-signing.cpp:63] Parsing input... 2021-01-29 06:48:25 readMessage() [chrome-token-signing.cpp:43] Request(107): {"type":"VERSION","nonce":"ksn7irqqd6tp9i7p","src":"page.js","origin":"https://hwcrypto.github.io","tab":2} 2021-01-29 06:48:25 sendMessage() [chrome-token-signing.cpp:51] Response(88) { "api": 1, "nonce": "ksn7irqqd6tp9i7p", "result": "ok", "version": "1.1.3.539" }

2021-01-29 06:48:25 main() [chrome-token-signing.cpp:63] Parsing input... 2021-01-29 06:48:25 readMessage() [chrome-token-signing.cpp:43] Request(132): {"type":"CERT","lang":"en","filter":"SIGN","nonce":"ugdbinfmfsdzg0j5","src":"page.js","origin":"https://hwcrypto.github.io","tab":2} 2021-01-29 06:48:25 atrList() [pkcs11path.cpp:70] found reader: Generic EMV Smartcard Reader 0 2021-01-29 06:48:25 atrList() [pkcs11path.cpp:83] Set ATR = 3BFA1800008031FE45FE654944202F20504B4903 for reader Generic EMV Smartcard Reader 0 2021-01-29 06:48:27 getCert() [nativecertificateselector.cpp:80] Certificate added to the memory store. 2021-01-29 06:48:28 sendMessage() [chrome-token-signing.cpp:51] Response(3028) { "api": 1, "cert": "308205C

Counter178 commented 3 years ago

Changed due to security reasons and is only meant for signing.

aixkalur commented 3 years ago

Btw in Safari this filter still works. If this is a "fix" like commented in here "https://www.id.ee/artikkel/ria-koos-partneritega-parandas-id-kaardi-brauserilaienduses-kriitilise-vea/"

Then i would say it's not a fix but rather kick in the but :-)

Also what point is to use versioning x.y.z when even changing z will bring breaking changes.

Counter178 commented 3 years ago

Btw in Safari this filter still works. If this is a "fix" like commented in here "https://www.id.ee/artikkel/ria-koos-partneritega-parandas-id-kaardi-brauserilaienduses-kriitilise-vea/"

Then i would say it's not a fix but rather kick in the but :-)

Also what point is to use versioning x.y.z when even changing z will bring breaking changes.

Out of curiosity, is the Safari situation still repeatable after machine restart?