If filename contains + sign with spaces, then container is not validated correctly

open-eid / digidoc4j

DigiDoc for Java. Javadoc:

http://open-eid.github.io/digidoc4j

GNU Lesser General Public License v2.1

73 stars 39 forks source link

If filename contains + sign with spaces, then container is not validated correctly #104

Closed aarepuusepp closed 1 year ago

aarepuusepp commented 2 years ago

Using Digidoc4j: 4.3.0 Container: bdoc Filename = jagamine + müük.pdf

Validation error: Cannot get the pointed bytes by a reference with uri='jagamine%20+%20m%C3%BC%C3%BCk.pdf'. Reason : [Unable to find document 'jagamine müük.pdf' (detached signature)] - filename contains 3 space chars between jagamine and müük

naare commented 2 years ago

Sorry for late reply. We are aware of problems in handling + character encoding. The final solution is not yet decided but next version will introduce changes regarding this.

naare commented 2 years ago

We have released Digidoc4j 5.0.0 where + character is not encoded/decoded as space.

naare commented 1 year ago

I will close the issue as the 5.0.0 has been released for a year and no additional feedback has been given.