open-eid / digidoc4j

DigiDoc for Java. Javadoc:
http://open-eid.github.io/digidoc4j
GNU Lesser General Public License v2.1
72 stars 40 forks source link

Bump bouncycastle version to 1.68 #92

Closed ErkoRisthein closed 3 years ago

ErkoRisthein commented 3 years ago
ErkoRisthein commented 3 years ago

Please let me know what kind of errors you're getting. Everything's passing in CI: https://github.com/Producement/digidoc4j/runs/1792194294 Both on Travis and Gitlab Actions, on all Java versions (8, 11, 15)

naare commented 3 years ago

First of all thank you for the contribution. The problem with this pull request is that it concludes many different changes. In future please keep pull requests to one specific change (eg. BC upgrade only, etc). We are dropping the travis-ci usage + we may need testing on specific Ubuntu version. This means as a package the pull request conflicts with our needs. We will accept it shortly and apply the changes we need on top of it later on.

ErkoRisthein commented 3 years ago

Cheers, let me know if there's anything I can help you with.