Incorrect DeviceAuthentication's sessionTranscript format - Githubissues

open-eid / eudi-qeaa-rp-mock

MIT License

0 stars 1 forks source link

Incorrect DeviceAuthentication's sessionTranscript format #2

Closed ydanneg closed 6 months ago

ydanneg commented 6 months ago

According to ISO/IEC 18013-5:2021 and your own documentation sessionTranscript structure is an array type containing following elements:

Element	Description	Encoding
DeviceEngagementBytes	It MUST be set to null.	array
EReaderKeyBytes	It MUST be set to null.	null
Handover	It MUST be set to OpenID4VPHandover structure.	array

But current implementation have the wrong structure that contains only Handover element: https://github.com/open-eid/eudi-qeaa-rp-mock/blob/400eee71c20c28e1885bc947e53865ec20ac7cd7/src/main/java/ee/ria/eudi/qeaa/rp/util/MDocUtil.java#L72-L73

aarmam commented 6 months ago

Related issue open-eid/eudi-qeaa-wallet-mock#5