search

open-eid / gentoo

Gentoo ebuild (community provided)
10 stars 14 forks source link

Make the ugly fix slightly less ugly #21

Closed monoidic closed 6 years ago

monoidic commented 6 years ago

To "fix" the "ugly hack" for #18 This will split sandbox-compat.patch into the actual patch itself and add the required files seperately. This should be cleaner and make updating the files seperately simpler.

monoidic commented 6 years ago

Alright. I'm not sure on a specific source for the .qrc though, unless linking https://github.com/open-eid/qdigidoc/wiki/DeveloperTips#building-in-sandboxed-environment or just leaving that blank is okay. Got any ideas?

metsma commented 6 years ago

You can leave blank or link to this article? Can you add comments before copy statement, then it seems more natural to read. And maybe qrc to first with this wiki link

urmet commented 6 years ago

Oh, nice. One tiny change though. In src_prepare() use cmake-utils_src_prepare instead of default. With default you get an annoying warning * cmake-utils_src_prepare has not been run, please open a bug on https://bugs.gentoo.org/

urmet commented 6 years ago

Thanks :)