search

open-eid / gentoo

Gentoo ebuild (community provided)
10 stars 14 forks source link

Bump qdigidoc4 to 4.4.0 with added depencendy on flatbuffers #65

Open mattiasMerilai opened 5 months ago

mattiasMerilai commented 5 months ago

Flatbuffers seem to be required to build now.

monoidic commented 4 months ago

You can just drop the version specifiers from dev-libs/opensc and dev-libs/libdigidocpp because only acceptable versions are available now. The append-cppflags "-DOF=_Z_OF" is also dead becase a) this macro rename was dropped by Gentoo, and b) it does not seem like OF() is in use in qdigidoc4 anyhow. If it was, then this would actually cause build failures., as _Z_OF is undefined.

mattiasMerilai commented 4 months ago

Sorted.

monoidic commented 4 months ago

Something else I forgot to add - run pkgdev manifest to generate the required line in the manifest file.

mattiasMerilai commented 4 months ago

Oh yeah, here you go.

jaakristioja commented 3 months ago

https://github.com/open-eid/DigiDoc4-Client/commit/e08c566a7426d04ca6549a73a25a1fe41eb0ab7a which added the dependency on FlatBuffers, also added the dependency on zlib, so I think sys-libs/zlib should also be added to RDEPEND.

Otherwise, looks fine to me.