Closed ljavorsk closed 7 months ago
@metsma Could you please review? It is related to the issue https://github.com/open-eid/libdigidocpp/issues/569
Changed to not check the version at all
Hi, can this MR be merged?
We have to test it before we can merge it. If there are no problems during testing, then we will merge it as soon as possible.
Can you please rebase to latest master to fix github actions and provide fedora builds with minizip-ng (needs probably installing minizip-ng-devel package?)
Rebased. Builds are here: https://copr.fedorainfracloud.org/coprs/ljavorsk/minizip-ng/build/6880707/
It requires both minizip-ng-compat-devel
and zlib-ng-compat-devel
(same as I've changed here: https://src.fedoraproject.org/rpms/libdigidocpp/pull-request/4#request_diff). I left the zlib-devel
because it's provided/obsoleted by zlib-ng-compat-devel
.
I was reffering to this project github action builds
https://github.com/open-eid/libdigidocpp/blob/master/.github/workflows/build.yml#L87
I've just added a new commit fixing the deps in Fedora. I used the old names because the new names work only since Fedora 40. However, the old names are working in Fedora 40 so don't worry
Fedora has switched to
minizip-ng
(with the compat mode) and these patches fixed the failed build oflibdigidocpp
.You can see more here: https://src.fedoraproject.org/rpms/libdigidocpp/pull-request/4
Signed-off-by: Lukas Javorsky ljavorsk@redhat.com