search

open-eid / libdigidocpp

Libdigidocpp library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards. Documentation http://open-eid.github.io/libdigidocpp
Other
97 stars 45 forks source link

Support minizip-ng build #574

Closed ljavorsk closed 7 months ago

ljavorsk commented 8 months ago

Fedora has switched to minizip-ng (with the compat mode) and these patches fixed the failed build of libdigidocpp.

You can see more here: https://src.fedoraproject.org/rpms/libdigidocpp/pull-request/4

Signed-off-by: Lukas Javorsky ljavorsk@redhat.com

ljavorsk commented 8 months ago

@metsma Could you please review? It is related to the issue https://github.com/open-eid/libdigidocpp/issues/569

ljavorsk commented 8 months ago

Changed to not check the version at all

ljavorsk commented 7 months ago

Hi, can this MR be merged?

kristelmerilain commented 7 months ago

We have to test it before we can merge it. If there are no problems during testing, then we will merge it as soon as possible.

metsma commented 7 months ago

Can you please rebase to latest master to fix github actions and provide fedora builds with minizip-ng (needs probably installing minizip-ng-devel package?)

ljavorsk commented 7 months ago

Rebased. Builds are here: https://copr.fedorainfracloud.org/coprs/ljavorsk/minizip-ng/build/6880707/

It requires both minizip-ng-compat-devel and zlib-ng-compat-devel (same as I've changed here: https://src.fedoraproject.org/rpms/libdigidocpp/pull-request/4#request_diff). I left the zlib-devel because it's provided/obsoleted by zlib-ng-compat-devel.

metsma commented 7 months ago

I was reffering to this project github action builds

https://github.com/open-eid/libdigidocpp/blob/master/.github/workflows/build.yml#L87

ljavorsk commented 7 months ago

I've just added a new commit fixing the deps in Fedora. I used the old names because the new names work only since Fedora 40. However, the old names are working in Fedora 40 so don't worry