search

open-eid / qdigidoc

DEPRECATED DigiDoc3 Client is a program that can be used to sign digitally with ID-card and Mobile-ID, check the validity of digital signatures and open and save documents inside the signature container.
http://installer.id.ee
GNU Lesser General Public License v2.1
26 stars 7 forks source link

"Building in sandboxed environment" paragraph is prone to misunderstandings #144

Closed Germano0 closed 6 years ago

Germano0 commented 6 years ago

At page https://github.com/open-eid/qdigidoc/wiki/DeveloperTips#building-in-sandboxed-environment you can read replace

Since https://github.com/open-eid/qdigidoc/blob/master/client/CMakeLists.txt#L23 does not contain set( RC_FILES images/images.qrc ${CMAKE_CURRENT_BINARY_DIR}/tr.qrc ${CMAKE_CURRENT_BINARY_DIR}/TSL.qrc ) but it contains set_source_files_properties( Application_mac.mm PROPERTIES COMPILE_FLAGS "-fobjc-arc" ) I think the paragraph is prone to misunderstandments, and IMHO it could be interpreted as:

Option 1 replace set( RC_FILES images/images.qrc ${CMAKE_CURRENT_BINARY_DIR}/tr.qrc ${CMAKE_CURRENT_BINARY_DIR}/TSL.qrc ) and set_source_files_properties( Application_mac.mm PROPERTIES COMPILE_FLAGS "-fobjc-arc" ) with set( RC_FILES images/images.qrc ${CMAKE_CURRENT_BINARY_DIR}/tr.qrc TSL.qrc )

Option 2 I look at https://github.com/open-eid/qdigidoc/blob/master/client/CMakeLists.txt#L23 and I think "oh but the URL does not contain" set( RC_FILES images/images.qrc ${CMAKE_CURRENT_BINARY_DIR}/tr.qrc ${CMAKE_CURRENT_BINARY_DIR}/TSL.qrc ) that I saw right under the URL in the wiki page, but it contains set_source_files_properties( Application_mac.mm PROPERTIES COMPILE_FLAGS "-fobjc-arc" ) and I don't know which one I have to replace with set( RC_FILES images/images.qrc ${CMAKE_CURRENT_BINARY_DIR}/tr.qrc TSL.qrc )

metsma commented 6 years ago

Code is changed wiki outdated, please update and see how it is done in qesteidutil https://github.com/open-eid/qesteidutil/tree/master/fedora

Germano0 commented 6 years ago

please update and see how it is done in qesteidutil https://github.com/open-eid/qesteidutil/tree/master/fedora

I am the author of the .spec file in that URL :-)

abitrolly commented 6 years ago

@metsma maybe migrate the wiki to docs/ repository to make it updated with code?

metsma commented 6 years ago

This does not to resolve the problem, remember to update docs on code change. I will update the TSL part later

metsma commented 6 years ago

https://ec.europa.eu/digital-single-market/en/eu-trusted-lists-trust-service-providers

metsma commented 6 years ago

Updated the wiki

Germano0 commented 6 years ago

Same with

Replace line https://github.com/open-eid/qt-common/blob/master/CMakeLists.txt#L28 qt5_add_resources( SOURCES ${CMAKE_CURRENT_BINARY_DIR}/config.qrc )

URL points to if( WIN32 ) instead the code to replace is qt5_add_resources( SOURCES ${CMAKE_CURRENT_BINARY_DIR}/config.qrc )

IMHO it would be better to quote the code to replace and simply mention the filename and path, without using URLs that become easly inconsistent after code updates

abitrolly commented 6 years ago

Can instructions to comment line be replaced with define. CMake probably supports them - at least if( APPLE ) look like a define to me.

abitrolly commented 6 years ago

This does not to resolve the problem, remember to update docs on code change.

But if anything in the process changes, it can be raised in PR. Commits can also be used to create cross-references between PRs and docs changes to make people aware of the docs.

I will update the TSL part later

I can help with uploading it to Ethereum blockchain. )

metsma commented 6 years ago

Wiki updated