search

open-ephys / bonsai-commutator

Bonsai support for Open Ephys commutators
https://open-ephys.github.io/commutator-docs/index.html
MIT License
0 stars 0 forks source link

Internalize `RotationAxis` property #10

Closed cjsha closed 1 week ago

cjsha commented 2 weeks ago

I propose that any rotation axis transformation should be performed in software by sending commands to the BNO055, and not be compensated for in the auto commutator node. I'm not sure what the added benefit is when the correct RotationAxis setting to work with all our headstages is supposed to be "0,0,1" anyway. I feel like this only makes commutator workflows more prone to errors. I might be missing something about why it's important to keep that property externalized though.

jonnew commented 2 weeks ago

Probably correct

The reason is to compensate for some bno data in which orientation is not standardized with positive z axis pointing along tether. We could say that the autocommutator expects this condition and it's up to source to make sure it's the case.

jonnew commented 1 week ago

Fixed in #11