search

open-ephys / bonsai-onix1-docs

Documentation for the OpenEphys.Onix1 Bonsai package
https://open-ephys.github.io/bonsai-onix1-docs/
Creative Commons Attribution Share Alike 4.0 International
0 stars 2 forks source link

Update submodule #133

Closed cjsha closed 2 weeks ago

cjsha commented 3 weeks ago

Resolve #129

bparks13 commented 3 weeks ago

@cjsha I would recommend instead of pointing to that commit, we should point to https://github.com/open-ephys/bonsai-onix1/commit/18dd66bcf586edc00506209491035ecce7142739. This is the commit that was tagged as v0.4.0, and as such should be a direct reflection of the state of the library that an end user can download.

@jonnew what do you think?

cjsha commented 3 weeks ago

there has only been one PR since v0.4.0 (at the time of updating the submodule pointer) and it doesn't seem like it would end up changing the docs, but yeah what you suggest is best practice. Whenever we have a new release, it would be cool to have a notification or something in the docs repo that it needs to point to a later version. I made a wishlist issue #141 for that