open-ephys / bonsai-onix1-docs

Documentation for the OpenEphys.Onix1 Bonsai package
https://open-ephys.github.io/bonsai-onix1-docs/
Creative Commons Attribution Share Alike 4.0 International
0 stars 2 forks source link

Content for spike detection tut #143

Closed cjsha closed 1 week ago

cjsha commented 3 weeks ago

Resolve #122

This commit is just the initial content

ChucklesOnGitHub commented 3 weeks ago

Added a style proposal that needs additional work, but covers style choices we can add to the sytle guide if we agree. Proposes:

Needs:

ChucklesOnGitHub commented 3 weeks ago

we need the list of scale and shift to be outside of the tutorial, since it should include parameters for all datastreams on the devices (auxiliary channels in rhd, LFP band in np1e).

jonnew commented 2 weeks ago

Related: open-ephys/bonsai-onix1#367

cjsha commented 2 weeks ago

Nice work, thanks Ceci. Some comments:

break up the text into steps

My first draft was too blocky, but this recent iteration feels a little too chopped up into bullet points to me. I try to find a middle ground in this commit, let me know what you think

I made it so that each step corresponds to a step corresponds to a part of the workflow.

tried to be specific about what "hardware" -> changed to "headstage"

I only reverted one instance of this because I use hardware to refer to breakout board and headstage64

named operations in order of occurence (specifically related to menu clicks)

I updated a page in the user gui that describes how to visualize data. I'm thinking we can link out to that instead of describing how to do it in the tutorial

correct the workflow with changes in the text (F32), etc

done, I think

headings and numbering to be correct

I'm not sure if the steps are better as headings as we discussed over discord or numbers. I'll let you handle this

add screenshots and videos

I added screenshots to the user guide where it describes how to visualize data. We don't have access to a live source of spikes, so I'm not sure how to add visualizers for those steps?

we need the list of scale and shift to be outside of the tutorial, since it should include parameters for all datastreams on the devices (auxiliary channels in rhd, LFP band in np1e).

I'm fine with this. We can make a page about this in the hardware docs? I made an issue about it https://github.com/open-ephys/onix-docs/issues/74

Additional proposals:

ChucklesOnGitHub commented 1 week ago

Cris, this is looking so good! I love the new flow.

I'm not sure if the steps are better as headings as we discussed over discord or numbers. I'll let you handle this

  • Changed big steps to headings. I think this is helpful since sections are in order but kind of independent functions. Allows linking easily and sections show up in the side menu. Lmk if this works, I think some sections might benefit from numbering inside: Stream ephys data into Bonsai
  • I only split up one section due to processing steps being different (channel selection, data conversion), still need to include the proper wf edit.

We don't have access to a live source of spikes, so I'm not sure how to add visualizers for those steps?

  • I think the Visualize Data section is general enough that a specific visualizer might not be necessary yet.
  • I could take screenshots of waveforms picked up from noise but this is not ideal :/

I made an issue about it https://github.com/open-ephys/onix-docs/issues/74

  • after we finish this, we can update the tutorial.
  • i couldn't find the edits I had made to the table