Closed cjsha closed 1 week ago
Added a style proposal that needs additional work, but covers style choices we can add to the sytle guide if we agree. Proposes:
Needs:
we need the list of scale and shift to be outside of the tutorial, since it should include parameters for all datastreams on the devices (auxiliary channels in rhd, LFP band in np1e).
Related: open-ephys/bonsai-onix1#367
Nice work, thanks Ceci. Some comments:
break up the text into steps
My first draft was too blocky, but this recent iteration feels a little too chopped up into bullet points to me. I try to find a middle ground in this commit, let me know what you think
I made it so that each step corresponds to a step corresponds to a part of the workflow.
tried to be specific about what "hardware" -> changed to "headstage"
I only reverted one instance of this because I use hardware to refer to breakout board and headstage64
named operations in order of occurence (specifically related to menu clicks)
I updated a page in the user gui that describes how to visualize data. I'm thinking we can link out to that instead of describing how to do it in the tutorial
correct the workflow with changes in the text (F32), etc
done, I think
headings and numbering to be correct
I'm not sure if the steps are better as headings as we discussed over discord or numbers. I'll let you handle this
add screenshots and videos
I added screenshots to the user guide where it describes how to visualize data. We don't have access to a live source of spikes, so I'm not sure how to add visualizers for those steps?
we need the list of scale and shift to be outside of the tutorial, since it should include parameters for all datastreams on the devices (auxiliary channels in rhd, LFP band in np1e).
I'm fine with this. We can make a page about this in the hardware docs? I made an issue about it https://github.com/open-ephys/onix-docs/issues/74
Additional proposals:
Cris, this is looking so good! I love the new flow.
Fantastic to have a visualizers guide outside of the tutorial
I really motivated this incorrectly by calling it spike tutorial. It's a signal processing tutorial for ephys data. I want to show people how to do things they are used to doing once they stick a probe in the brain: channel mapping/selection, filtering, some detection of sorts so they can start working in Bonsai. Help them answer the q "do i have any good data?" which is usually "where are my spikes?" within Bonsai. There are better ways of doing this, both for spike visualization (ephys socket) and for real-time processing for closed-loop applications (spike sorting and ripple detection nodes not available/mainstream yet). re: Jon's comment here. In this basic signal processing tutorial, putting a threshold on filtered data is an example of what could be done on high-pass filtered data, as could be doing phase detection on low-pass filtered data.
Language revision: I want to use plain language. I'm looking out for fluff, jargon, over-complex words and words like "simply" and "just" (it's important), as well as spellchecking. We could do a small language style list we both agree with.
I'm not sure if the steps are better as headings as we discussed over discord or numbers. I'll let you handle this
- Changed big steps to headings. I think this is helpful since sections are in order but kind of independent functions. Allows linking easily and sections show up in the side menu. Lmk if this works, I think some sections might benefit from numbering inside: Stream ephys data into Bonsai
- I only split up one section due to processing steps being different (channel selection, data conversion), still need to include the proper wf edit.
We don't have access to a live source of spikes, so I'm not sure how to add visualizers for those steps?
- I think the Visualize Data section is general enough that a specific visualizer might not be necessary yet.
- I could take screenshots of waveforms picked up from noise but this is not ideal :/
I made an issue about it https://github.com/open-ephys/onix-docs/issues/74
- after we finish this, we can update the tutorial.
- i couldn't find the edits I had made to the table
Resolve #122
This commit is just the initial content