Add configuration dialog for ONI context

glopesdev commented 1 year ago

First iteration can adapt functionalities of the existing ONI Context GUI of the original package, accessing liboni directly.

glopesdev commented 4 months ago

@jonnew I am assuming we are moving this to the 0.2.0 milestone.

jonnew commented 4 months ago

Yes, I think thats reasonable.

jonnew commented 3 months ago

During a meeting, we started discussing what this would actually look like and realized there are a lot of details to consider

Should this configuration dialog actually access hardware?
Should it reflect the state that would be applied during the configuration chain? Should it apply the configuration chain? This is important because be default, e.g., the headstage ports are powered off. Does it need to turn them on to figure out the true device table or just tell the user what will be applied in the configuration chain if the devices are actually present when the play button is pressed.
etc.

To be honest, as the conversation progressed, we began to question the utility of this idea at all. The library has improved significantly compared to Bonsai.ONIX in terms of abstracting away the hardware details. Providing a direct window into the device table or showing real hardware state seems like a move in the other direction.

There is one major type of information that it would be nice to have access to though which is the hardware IDs, firmware versions, etc. that are produced by the following function:

https://github.com/open-ephys/onix-bonsai-onix1/blob/7ac700fb8a696d4d9f8d97c9d1b85765b9951ca6/OpenEphys.Onix1/ContextTask.cs#L479C26-L479C32

This is useful diagnostic information that is not exposed in a way that the user can currently save or examine.

We are moving this to 0.3.0 for this reason.

open-ephys / bonsai-onix1

Add configuration dialog for ONI context #19