search

open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System
https://open-ephys.github.io/onix1-bonsai-docs
MIT License
4 stars 3 forks source link

Add GUI for Neuropixels V1e #231

Closed bparks13 closed 1 month ago

bparks13 commented 1 month ago

This PR aims to add a dialog GUI for the NeuropixelsV1e headstage.

Controls are based on NeuropixelsV2e GUI, for more info on the controls see #214.

One major difference between V1 and V2 is that V1 has two separate calibration files that are required (Gain and ADC). The probe will not be visible unless both files exist and are selected.

Closes #106

jonnew commented 1 month ago

We will need to bring the changes from #243 into this PR, I suppose.

bparks13 commented 1 month ago

@jonnew actually we won't need to, the scaling issues occurred at the device/headstage level, not the common framework level. Meaning, I was able to fix the NeuropixelsV2e dialogs in #243, which modifies the dialogs that are in main, and I took the same steps to fix the NeuropixelsV1e dialogs. I just need to finish testing and push that commit to this PR.

jonnew commented 1 month ago

@bparks13 I made some minor changes to make the NP GUIs more uniform. Once you confirm I have not broken anything, lets merge this.