open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System
https://open-ephys.github.io/onix1-bonsai-docs
MIT License
4 stars 3 forks source link

Channel configurations do not respect file properties on load #271

Closed bparks13 closed 3 weeks ago

bparks13 commented 1 month ago

NeuropixelsV2QuadShankProbeConfiguration and NeuropixelsV1eProbeConfiguration both have an issue when loading an existing file. What happens is that the DeviceChannelIndices field is pulled out and then saved, but the rest of the fields are discarded. This is due to how I am creating a deep-copy; to fix it, I will need to update OpenEphys.ProbeInterface.NET to create clones of the fields, or use the newly modified public Probe copy constructor as a way to copy the whole probe without keeping the pointer reference.

This is currently being fixed in the issue-252 branch.