search

open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System
https://open-ephys.github.io/onix1-bonsai-docs
MIT License
4 stars 3 forks source link

ChannelMap should be a fixed size array #280

Open jonnew opened 1 month ago

jonnew commented 1 month ago

In the case of all neuropixels yet supported, this should hold 384 elements:

https://github.com/open-ephys/onix-bonsai-onix1/blob/3fdcec67f5f5d548ddf9125d7859565b55a48d08/OpenEphys.Onix1/NeuropixelsV1eProbeConfiguration.cs#L156

Therefore, List is probably not the right type. If we change to an array, we must diligently propagate the array interface downstream (we cant just perform ToList() at the next step).