search

open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System
https://open-ephys.github.io/onix1-bonsai-docs
MIT License
4 stars 3 forks source link

Consolidate passthrough BNO055 configure and data operators #281

Closed jonnew closed 2 weeks ago

jonnew commented 1 month ago

The BNO055 has a unique configuration and data operator for each of the passthrough-based headstage it works with. For example:

https://github.com/open-ephys/onix-bonsai-onix1/blob/3fdcec67f5f5d548ddf9125d7859565b55a48d08/OpenEphys.Onix1/ConfigureNeuropixelsV2eBno055.cs#L11

There are others in

This seems very redundant. Why can they not be consolidated? will in be confusing that ConfigureBno055 and Bno055Data is not he same as whatever consolidated class we come up with?

jonnew commented 4 weeks ago

While this could be added on top of existing operators, they would likely be marked as deprecated. For this reason, Im going to change this the the 1.0.0 milestone.