Functional onix-headstage-neuropix1 support

open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System

https://open-ephys.github.io/onix1-bonsai-docs

MIT License

4 stars 3 forks source link

Functional onix-headstage-neuropix1 support #315

Open jonnew opened 4 days ago

jonnew commented 4 days ago

Needs XML docs
Needs GUI integration
Needs testing with more than one probe

jonnew commented 4 days ago

@bparks13

I removed the "e" suffix in a bunch of NeuropixelsV1e classes that are actually generic across headstages.
This headstage is needs GUI integration
It also needs xml docs, but I can do that once you've done the GUI work.

jonnew commented 12 hours ago

It seems like there is a little left over icon at the bottom of the GUI still:

jonnew commented 12 hours ago

When i run the GUI on a ConfigureNeuropixelsV1f (no headstage), there is a "Probe A" indicator in the window title:

I dont think that should be there because the A vs. B is given by the device address in this case. Basically, nothing needs to change compared to the ConfigureNeuropixelsV1e in this case.

bparks13 commented 12 hours ago

@jonnew The icon is supposed to be there, it indicates if the calibration files are valid, and if the serial numbers of the files match. This does not touch hardware, but is meant as an easy way to see which files are currently loaded and if they match.

However, the text is being cut off, which is incorrect, so that needs to be fixed.

jonnew commented 12 hours ago

When I see the circle arrow icon, I expect to be able to click it to refresh, but that does not seem to be the case here. I would be a yellow warning triagle or something to indicate that cal files are needed