search

open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System
https://open-ephys.github.io/onix1-bonsai-docs
MIT License
4 stars 3 forks source link

Rename from `ChannelConfiguration` to `ProbeGroup` #321

Open bparks13 opened 1 day ago

bparks13 commented 1 day ago

In many places, the name ChannelConfiguration was used for probe groups prior to any channel configurations were created. However, this can be a cause for confusion, and should be renamed for clarity.

An example of an existing place this occurs is below:

https://github.com/open-ephys/onix-bonsai-onix1/blob/de7bb7ef19d2c8c59d78c3a504a701c6ee53bd3a/OpenEphys.Onix1/NeuropixelsV2QuadShankProbeConfiguration.cs#L213

jonnew commented 7 hours ago

ProbeGroup is not as clear to me as ChannelConfiguration. If the later is somehow incorrect, then lets find a happy medium that describes what the type does. ProbeGroup just doesn't give much information IMO.