search

open-ephys / liboni

API for controlling ONI-compliant hardware
https://open-ephys.github.io/onix-docs/API%20Reference/index.html
0 stars 5 forks source link

Maybe separate the riffa driver from clroni #4

Open aacuevas opened 3 years ago

aacuevas commented 3 years ago

Right now, the clroni nuget package contains both the main libONI library and the onix-specific riffa driver.

Maybe it should be best to have them in separate packages, to ease the introduction of future different drivers, which could then be distributed as individual packages.

Adittionaly, maybe the riffa driver should be renamed as onix-riffa, to make clear that it is part of the ONIX ecosystem.

jonnew commented 3 years ago

Although this feels clean, there is a reason why e.g. a FLIR SDK is like 1 GB. They just keep dumping all kinds of hardware compatibility libraries in there so it it always works. I'm a bit weary about dependencies getting stitched together properly

aacuevas commented 3 years ago

You are right. I can also see a dependency issue, like Bonsai.ONIX requiring clroni and a driver but, which driver? So maybe bundling together the drivers we, as the maintainers, also develop is the best idea.

But we should make sure that any third party can create an onidriver and make it work with clroni without having to go through us.

jonnew commented 3 years ago

To the last point -- absolutely.