open-ephys / plugin-GUI

Software for processing, recording, and visualizing multichannel electrophysiology data
https://open-ephys.org/gui
GNU General Public License v3.0
193 stars 683 forks source link

Disabling channel 1 in channel mapper zeros all channels #591

Open aacuevas opened 11 months ago

aacuevas commented 11 months ago

In the channel mapper, disabling the channel marked as "1" causes all the channels to be of zero value. This is independent of the position on the "1" channel in the map.

jsiegle commented 11 months ago

This is due to the way that we are connecting channels across processors. JUCE's built-in method for wiring up the processor graph check for connections between every possible combination of channels across all processors, and is therefore extremely slow for high channel counts. To speed this up, we modified it to only check the first channel. However, this means the Channel Map won't get connected if channel 1 is disabled (even if you change the channel order).

The wiring algorithm is fortunately much more efficient in JUCE 7, so this will get fixed in the next major GUI release.