open-feature / dotnet-sdk-contrib

OpenFeature Providers and Hooks for .NET
https://openfeature.dev
Apache License 2.0
30 stars 23 forks source link

feat: Introduce flipt provider for dotnet #285

Closed jeandreidc closed 1 month ago

jeandreidc commented 2 months ago

Flipt.io provider for dotnet

Initial version of flipt.io provider for dotnet.

Related Issues

None

Notes

Follow-up Tasks

jeandreidc commented 1 month ago

Updated @markphelps

toddbaert commented 1 month ago

@jeandreidc Great work! Thanks a lot. There's only 3 small things blocking my approval:

markphelps commented 1 month ago

Thanks again @jeandreidc !! Looks great!

cc @toddbaert

markphelps commented 1 month ago

@beeme1mr @toddbaert is there anything else blocking this from merge?

Thanks again @jeandreidc !!

beeme1mr commented 1 month ago

Approved, but there's an issue with the build. Feel free to ping me so I can retrigger CI once the issue has been addressed.

jeandreidc commented 1 month ago

Fixed the build issue please re-run the workflows, TIA! @beeme1mr

jeandreidc commented 1 month ago

Hello @beeme1mr was it merged by mistake? I was waiting for the build pipeline to pass

beeme1mr commented 1 month ago

Yes, I thought the tests passed but apparently they hadn't started.

beeme1mr commented 1 month ago

@jeandreidc sorry about that. Would you mind addressing the build issue in a separate pr? On the bright side, the ci should run automatically since it's no longer your first contribution 😀

We're going to revert the merge. Could you please open a new PR referencing this one?