search

open-feature / dotnet-sdk-contrib

OpenFeature Providers and Hooks for .NET
https://openfeature.dev
Apache License 2.0
30 stars 23 forks source link

Release Failed #295

Closed beeme1mr closed 1 month ago

beeme1mr commented 1 month ago

After merging https://github.com/open-feature/dotnet-sdk-contrib/pull/293, the publishing step fails.

Command the publishing step is failing on Run dotnet build --configuration Release --no-restore -p:Deterministic=true

output

Error: D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\FliptToOpenFeatureConverterTest.cs(23,52): error xUnit1026: Theory method 'EvaluateBooleanAsync_GivenHttpRequestException_ShouldHandleHttpRequestException' on test class 'FliptToOpenFeatureConverterTest' does not use parameter 'expectedOpenFeatureErrorType'. (https://xunit.github.io/xunit.analyzers/rules/xUnit1026) [D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\OpenFeature.Contrib.Providers.Flipt.Test.csproj::TargetFramework=net6.0]
Error: D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\FliptToOpenFeatureConverterTest.cs(64,16): error xUnit1026: Theory method 'EvaluateBooleanAsync_GivenNonExistentFlag_ShouldReturnDefaultValueWithFlagNotFoundError' on test class 'FliptToOpenFeatureConverterTest' does not use parameter 'flagKey'. (https://xunit.github.io/xunit.analyzers/rules/xUnit1026) [D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\OpenFeature.Contrib.Providers.Flipt.Test.csproj::TargetFramework=net6.0]
Error: D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\FliptToOpenFeatureConverterTest.cs(86,52): error xUnit1026: Theory method 'EvaluateAsync_GivenHttpRequestException_ShouldHandleHttpRequestException' on test class 'FliptToOpenFeatureConverterTest' does not use parameter 'expectedOpenFeatureErrorType'. (https://xunit.github.io/xunit.analyzers/rules/xUnit1026) [D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\OpenFeature.Contrib.Providers.Flipt.Test.csproj::TargetFramework=net6.0]
Error: D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\FliptToOpenFeatureConverterTest.cs(23,52): error xUnit1026: Theory method 'EvaluateBooleanAsync_GivenHttpRequestException_ShouldHandleHttpRequestException' on test class 'FliptToOpenFeatureConverterTest' does not use parameter 'expectedOpenFeatureErrorType'. (https://xunit.github.io/xunit.analyzers/rules/xUnit1026) [D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\OpenFeature.Contrib.Providers.Flipt.Test.csproj::TargetFramework=net462]
Error: D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\FliptToOpenFeatureConverterTest.cs(64,16): error xUnit1026: Theory method 'EvaluateBooleanAsync_GivenNonExistentFlag_ShouldReturnDefaultValueWithFlagNotFoundError' on test class 'FliptToOpenFeatureConverterTest' does not use parameter 'flagKey'. (https://xunit.github.io/xunit.analyzers/rules/xUnit1026) [D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\OpenFeature.Contrib.Providers.Flipt.Test.csproj::TargetFramework=net462]
Error: D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\FliptToOpenFeatureConverterTest.cs(86,52): error xUnit1026: Theory method 'EvaluateAsync_GivenHttpRequestException_ShouldHandleHttpRequestException' on test class 'FliptToOpenFeatureConverterTest' does not use parameter 'expectedOpenFeatureErrorType'. (https://xunit.github.io/xunit.analyzers/rules/xUnit1026) [D:\a\dotnet-sdk-contrib\dotnet-sdk-contrib\test\OpenFeature.Contrib.Providers.Flipt.Test\OpenFeature.Contrib.Providers.Flipt.Test.csproj::TargetFramework=net462]
Build FAILED.
beeme1mr commented 1 month ago

It looks like these warnings need to be addressed.

https://github.com/open-feature/dotnet-sdk-contrib/pull/293/files#diff-01c3fc9ea3a682195c0edbd902227d37f82f7f20af7194fde44dba3aa665e663