Closed austindrenski closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f2b9b03
) 0.00% compared to head (71230e8
) 93.86%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Built this locally and everything looks sane to me!
Ran across this while working on open-feature/dotnet-sdk#264, and tldr; if there's more than one project under
src/
, having the<PackageId>
hard-coded inbuild/Common.prod.props
causes MSBuild to panic.There are two options to fix this:
Since NuGet defaults
PackageId
to the assembly name, I'm opting for (2), but if I've overlooked some nuance/custom build steps that require settingPackageId
explicitly, then we could just as well fallback to (1).Example
Related