search

open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
62 stars 17 forks source link

feat!: add cancellation tokens #184

Closed austindrenski closed 4 months ago

austindrenski commented 8 months ago

See: https://github.com/open-feature/dotnet-sdk/pull/154#issuecomment-1894703244

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a14f6c) 0.00% compared to head (0dc319f) 94.73%.

:exclamation: Current head 0dc319f differs from pull request most recent head b7b770a. Consider uploading reports for the commit b7b770a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #184 +/- ## ========================================= + Coverage 0 94.73% +94.73% ========================================= Files 0 23 +23 Lines 0 931 +931 Branches 0 93 +93 ========================================= + Hits 0 882 +882 - Misses 0 29 +29 - Partials 0 20 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kinyoklion commented 5 months ago

We should maybe update the conventional commit tag to have an exclamation point. Makes it easy to see that it needs to be held off.

toddbaert commented 5 months ago

I'm assigning this to myself. Next week I'll work on cleaning it up, which will hopefully also help me understand how we can best use these tokens in terms of how they integrate with the rest of the SDK's semantics.

We should maybe update the conventional commit tag to have an exclamation point. Makes it easy to see that it needs to be held off.

Did this, thanks @kinyoklion

toddbaert commented 4 months ago

I've started on this and https://github.com/open-feature/dotnet-sdk/pull/185

toddbaert commented 4 months ago

Closing and continuing with https://github.com/open-feature/dotnet-sdk/pull/268